Scroll-y menus #62819
Merged
Scroll-y menus #62819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomoreno
approved these changes
Nov 12, 2018
|
@sbatten please bring up to date with master |
|
Yeah possibly, but I prefer to apply the changes on top of master. And besides, there is a merge conflict too. |
|
@bpasero updated and conflicts resolved |
bpasero
approved these changes
Nov 21, 2018
There was a problem hiding this comment.
@sbatten yeah works nicely, some feedback:
- looks like the onscroll emitter is never disposed
- the scrollbar is a bit hard to see in high contrast themes (see below)
- the scrollbar should probably always be visible even when the mouse is not over the menu for accessibility reasons (see how quick open always shows a scrollbar)
- the scrollbar does not update its position when I navigate using the keyboard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a menu is created, set a max height and use scrollable element. There is room for improvement but this only takes a visible effect when needed and in that case, it is certainly better than the current situation.
Not having used the scrollableelement class before and due the strange behavior of overflow with regards to submenus, please review carefully.
fixes #52533